Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cfn-include): allow numbers to be passed to string properties #9849

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

skinny85
Copy link
Contributor

CloudFormation allows treating numbers and strings interchangeably.
We previously allowed passing strings as numbers,
but this change allows the conversion in the second direction:
passing numbers as strings.

Fixes #9784


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

CloudFormation allows treating numbers and strings interchangeably.
We previously allowed passing strings as numbers,
but this change allows the conversion in the second direction:
passing numbers as strings.

Fixes aws#9784
@skinny85 skinny85 self-assigned this Aug 20, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 20, 2020
@skinny85 skinny85 requested review from njlynch and shivlaks August 20, 2020 00:15
@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d825128
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4c8c6f1 into aws:master Aug 20, 2020
@skinny85 skinny85 deleted the fix/cfn-include-number-as-string branch September 2, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cfn-include] Should treat numbers as valid strings
3 participants