chore(lambda): current version for singleton functions

[jogold]

Add currentVersion for singleton functions. This makes it possible to
use them for Lambda@Edge.

To achieve this, make ensureLambda() return a Function and not an IFunction
(which now allows to remove the default implementation of _checkEdgeCompatibilty()
in FunctionBase).

Also remove deprecated calls to addVersion() introduced in #9562.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[robertd]

@jogold Will this also allow currentVersion to be called for imported Lambda functions?

[jogold]

@jogold Will this also allow currentVersion to be called for imported Lambda functions?

No, but if you're importing you know the version, no?:

lambda.Version.fromVersionArn(this, 'Version', 'arn:aws:lambda:region:account-id:function:function-name:version')

[robertd]

@jogold Yeah I do, but CloudFront construct expects lambda.currentVersion param. #9901

P.S. Sorry for the off-topic discussion.

[nija-at]

Curious why you've removed the default implementation of _checkEdgeCompatibility() and changed this line.

Why not run _checkEdgeCompatibility() if it is any kind of FunctionBase?

[jogold]

The only reason we needed to implement it at the FunctionBase level was because the singleton function's ensureLambda() was returning an IFunction instead of a Function which is incorrect.

Now that the singleton function is fixed (in terms of typing) we don't need this at the FunctionBase level: we will never check imported functions for edge compatibility.

[jogold]

Actually the fact that the type Function was aliased as LambdaFunction in the singleton-function.ts file made me use FunctionBase in #9562 because when I tried with Function it was referring to a normal function... I could have used Function (LambdaFunction) in #9562 already.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: cb31b39
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).