Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-ec2): fix SecurityGroup's all egress traffic rule #998

Merged
merged 10 commits into from
Oct 25, 2018
Merged

fix(aws-ec2): fix SecurityGroup's all egress traffic rule #998

merged 10 commits into from
Oct 25, 2018

Commits on Sep 28, 2018

  1. docs(aws-ec2): Explain Security Groups better 

    Explain how to add rules to Security Groups, and rewrite the 
section on the Connections object a bit.

Fixes #799.
    @rix0rrr
    rix0rrr authored Sep 28, 2018
    Configuration menu
    Copy the full SHA
    cf5f9c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Mention that no egress rules = all traffic

    Rico Huijbers committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    ad7c31c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. fix(aws-ec2): SecurityGroups ensure outbound rules 

    Make "allowAllOutbound" traffic a property of a SecurityGroup. By making
the SecurityGroup aware of this configuration property, we can make sure
that future egress rules don't get added to the SecurityGroup. There's
no need to, because all traffic is allowed by default anyway.

If we don't do this, our behavior of adding reciprocal rules between
SecurityGroups conflicts with CloudFormation's behavior to strip the
"default outbound" rule when another rule gets added, and it becomes
impossible to configure "all outbound" traffic on a
SecurityGroup.

Fixes #987.
    Rico Huijbers committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    9c9f912 View commit details
    Browse the repository at this point in the history

  2. Update expectation

    Rico Huijbers committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    641d888 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. WIP

    Rico Huijbers committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    3fc6c75 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/huijbers/sg-docs' into huijbers/… 

    …explicit-outbound-asg
    Rico Huijbers committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    b168d0f View commit details
    Browse the repository at this point in the history

  3. Rename AllConnections() -> AllTraffic()

    Rico Huijbers committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    1e04e0f View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into huijbers/explicit-o… 

    …utbound-asg
    Rico Huijbers committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    ed013f6 View commit details
    Browse the repository at this point in the history

  5. Update expectations

    Rico Huijbers committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    e4b6b3e View commit details
    Browse the repository at this point in the history

  6. Make allowAllOutbound configurable for Lambda

    Rico Huijbers committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    95a39df View commit details
    Browse the repository at this point in the history