Add ability for skipping undecodable filenames #1038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028
So if you are running on posix platforms you will run into an issue if the file name was encoded differently than the system's set encoding, the
listdir()
call we make will not be able to decode the name properly.Before, if you hit this problem the whole process failed and it would do so silently. Now it warns the user with the appropriate message and just skips the file.
Here is an example of reproducing the fixed issue on an Amazon Linux, and what it looks like with this PR:
cc @jamesls @danielgtaylor