Parse --statistic-values values into a decimal type #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing the improved botocore param validation because we were previously setting this value to a string. We now set this value to a decimal.Decimal to ensure we have a valid type that will also pass the botocore param validation. While I was in the code, I also updated the code to use the new botocore CamelCasing from metric_data to MetricData. There was also some general test cleanup to switch the tests to assert_params_for_cmd2. Fixes aws#1036.
|
Looks good. 🚢 |
jamesls
added a commit
that referenced
this pull request
Dec 2, 2014
* fix-string-type: Add issue to changelog Parse --statistic-values values into a decimal type Conflicts: CHANGELOG.rst Closes #1039.
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing the improved botocore param validation because
we were previously setting this value to a string. We now set
this value to a decimal.Decimal to ensure we have a valid type
that will also pass the botocore param validation.
While I was in the code, I also updated the code to use the new
botocore CamelCasing from metric_data to MetricData. There was
also some general test cleanup to switch the tests to
assert_params_for_cmd2.
Fixes #1036.
cc @kyleknap @danielgtaylor