Handle broken pipe errors #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If stdout is being piped to another process and that process closes stdin, then we get an IOError with a broken pipe message. If the reading end of the pipe closes the pipe, we should just exit. This is a normal (and common) case and we shouldn't be printing an error message when this happens.
|
Looks good. 🚢 Even though coveralls shows a drop, you added a test for the case. So you are good. |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
* chore(version): set 0.14.3.dev1 version (aws#1112) (aws#1113) * Depend on development version of lambda-builders for dev builds (aws#1111) * Depend on development version of lambda-builders for dev builds * Adding prod.txt to manifest * Splitting dev and tool dependencies * fix(build): Resolve path after .aws-sam is created (aws#1110) * fix(build): Resolve path after .aws-sam is created * fix: build (make pr) * Design and implementation for producing debug build artifacts (aws#1095) * design: Initial Design for producing debug artifacts * initial implementation * Adding unit tests * Integration test with debug build mode * Adjust Design doc and add keyword arg to a call * fix(dotnet): init template fixes (aws#1117) * chore(version): set 0.15.0 (aws#1125) * Revert "Depend on development version of lambda-builders for dev builds (aws#1111)" (aws#1128) This reverts commit 7e9de790e23791ba176faff2030286db4007e503. * Bumping to Lambda Builders 0.3.0 (aws#1129) Bumping to Lambda Builders 0.3.0 * fix(func-tests): add dependency manager param (aws#1130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If stdout is being piped to another process and that process
closes stdin, then we get an IOError with a broken pipe message.
If the reading end of the pipe closes the pipe, we should just exit.
This is a normal (and common) case and we shouldn't be printing
an error message when this happens.
The error was being raised on the
.flush()call to the stream.Before:
After:
cc @kyleknap @danielgtaylor