Honor --endpoint-url in s3/s3api commands #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aws#1142. The issue was that the before-auth event was removed in the internal botocore auth refactor (between 1.7.4-1.7.5), but this handler was not updated. I've added an integration test that should catch this issue in the future.
|
🚢 |
jamesls
added a commit
that referenced
this pull request
Feb 23, 2015
kyleknap
pushed a commit
that referenced
this pull request
Feb 24, 2015
* release-1.7.12: Bumping version to 1.7.12 Update changelog with service updates Bumped CLI dependancy of bcdoc Add #1172 to the changelog Honor --endpoint-url in s3/s3api commands Remove unnecessary --recursive from sync command Update dependencies Update dependencies Prefix doc references with "cli:" Update event names to new bcdoc event names Add reference label and changed breadcrumbs Switched event class to use full name of command dynamo db examples Remove status code checks from s3 tests Update s3 end to end integration test to clients
kyleknap
pushed a commit
that referenced
this pull request
Feb 24, 2015
* release-1.7.12: Bumping version to 1.7.12 Update changelog with service updates Bumped CLI dependancy of bcdoc Add #1172 to the changelog Honor --endpoint-url in s3/s3api commands Remove unnecessary --recursive from sync command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142.
The issue was that the before-auth event was removed in the
internal botocore auth refactor (between 1.7.4-1.7.5), but
this handler was not updated. I've added an integration
test that should catch this issue in the future.
cc @kyleknap @danielgtaylor