Add topic guide for s3 configs #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents the config values added in aws#1122.
| :related command: s3 cp, s3 sync, s3 mv, s3 rm | ||
|
|
||
| The ``aws s3`` transfer commands, which include the ``cp``, ``sync``, ``mv``, | ||
| and ``rm`` commands, have additional configuration you can use to control |
There was a problem hiding this comment.
additional configuration ---> additional configuration parameters
|
It looks good. I would say a general comment is that in some places terminology is used like "task" that is not really defined anywhere. It would be nice if a sentence was given to introduce the term (i.e. what it encompasses) Also can you run the |
1 similar comment
jamesls
force-pushed
the
add-s3-config-topic
branch
from
5ce7a01
to
046b756
Compare
|
@kyleknap I believe I've incorporated all the feedback. Let me know if I missed anything. |
|
Looks good. Can you generate the topic-tags.json for your new topic as well? Otherwise, 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the config values added in #1122.
cc @kyleknap @danielgtaylor