Update events to emit model/session objects #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the events emitted in cli driver to emit service/operation object alternatives. This change allows handlers to be updated to not require service/operation objects. In many cases, some handlers took an `operation` object, but did not actually use this, so these changes were minimal. Note that this puts the CLI in an interim state. The plan is to not merge this into the develop branch until clidriver is switched over, but this will allow a common base for all customization switchovers to be based on.
|
This will fail until boto/botocore#487 is merged. It's been reviewed so I'll go ahead and merge and resubmit this build request. |
We don't really need the help text for these tests
| @@ -201,6 +201,9 @@ def test_no_paginate_arg(self): | |||
| p = aws('s3api list-objects --bucket %s --no-paginate' % bucket_name) | |||
| self.assertEqual(p.rc, 0, p.stdout + p.stderr) | |||
|
|
|||
| p = aws('s3api list-objects --bucket %s' % bucket_name) | |||
There was a problem hiding this comment.
Is this just to make sure pagination works? Its under the no pagination test though.
|
Looks good. I had just a few some small comments. |
|
LGTM |
|
Closing in favor of #1220, which is more comprehensive and includes this PR. |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the events emitted in cli driver
to emit service/operation object alternatives. This change
allows handlers to be updated to not require service/operation
objects.
In many cases, some handlers took an
operationobject, butdid not actually use this, so these changes were minimal.
Note that this puts the CLI in an interim state. The plan is
to not merge this into the develop branch until clidriver is
switched over, but this will allow a common base for all
customization switchovers to be based on. This is why
this is a pull against the clidriver-no-clients branch for its
base, not develop.
cc @kyleknap @danielgtaylor