Document preview services #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only care when a user tries to make a service call that they've opted into the preview service. They should be able to view docs without opting in.
| command_table[preview_service] = preview_cls( | ||
| cli_name=original_command.name, | ||
| session=session, | ||
| service_name=original_command._service_name, |
There was a problem hiding this comment.
I think you would would be able to get this from original_command.service_model.service_name
|
Implementation looks good. Had a few minor comments. 🚢 |
|
@kyleknap feedback incorporated, please take another look. |
|
Thanks. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of documentation, help commands, and preview services.
aws cloudfront helpwould still require you to opt into the preview. Now, only the actual service commands require you to opt in.Because of the way our doc system works, it's easy to add to the end of the description, but not so easy to add to the beginning of the documentation. Here's how this looks like with this change:
cc @kyleknap