Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when creating emr role with AWS_CA_BUNDLE #1468

Merged
merged 1 commit into from
Aug 26, 2015

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Aug 26, 2015

It is reported that there is a bug causing failure to create emr role,
when customer has an AWS_CA_BUNDLE setting in the environment.

When the bug occurs, running::

aws emr create-default-roles

fails with "SSLError" object has no attribute.

This commit should be able to fix that, and also fix the incorrect test cases.

@jamesls
Copy link
Member

jamesls commented Aug 26, 2015

:shipit: Please add an entry to the changelog as well. Thanks!

@rayluo rayluo force-pushed the bugfix-emr-create-default-roles branch 2 times, most recently from 463b0ab to 02bebad Compare August 26, 2015 17:24
@kyleknap
Copy link
Contributor

Looks good. 🚢

It is reported that there is a bug causing failure to create emr role,
when customer has an AWS_CA_BUNDLE setting in the environment.

When the bug occurs, running::

    aws emr create-default-roles

fails with "SSLError" object has no attribute.

This commit should be able to fix that, and also fix the incorrect test cases.
@rayluo rayluo force-pushed the bugfix-emr-create-default-roles branch from 02bebad to 09d811c Compare August 26, 2015 17:26
rayluo added a commit that referenced this pull request Aug 26, 2015
Fix a bug when creating emr role with AWS_CA_BUNDLE
@rayluo rayluo merged commit 4c4fcd1 into aws:develop Aug 26, 2015
@rayluo rayluo deleted the bugfix-emr-create-default-roles branch August 26, 2015 17:30
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants