Catch more specific exceptions in assume role provider #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To repro, call an aws command with an explicit ``--region`` and a non-existent profile: aws ec2 describe-instances --region us-east-1 --profile does-not-exist The issue was that the assume role provider was catching too general of an exception so the profile does not exist error was not being propogated. There's also a bug in botocore with how we're handling failures for lazily registered components. This is why we're seeing the "Unknown component" bug. This will require a separate PR to botocore.
|
Looks good. 🚢 |
|
🚢 |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
…#1515) * fix: Move validation of timeout is an int further down the stack * Fix casting floats to ints * pywin32 needs to be under 226 to work with virtualenv module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To repro, call an aws command with an explicit
--regionanda non-existent profile:
aws ec2 describe-instances --region us-east-1 --profile does-not-exist
The issue was that the assume role provider was catching too general
of an exception so the profile does not exist error was not being
propogated.
There's also a bug in botocore with how we're handling failures
for lazily registered components. This is why we're seeing the
"Unknown component" bug. This will require a separate PR
to botocore.
Before:
After:
cc @kyleknap @mtdowling @rayluo