Fix streaming output arg #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that there actually are unit tests for this, but we weren't checking the RC of the run command, only that the request params looked how we wanted them to. As a result, I've updated the base test class to check for expected RCs from the commands that are run. This caused the tests to fail and should ensure that if we break the streaming output arg customization, we'll get a test failure.
This is just due to the way the docs were being rendered so I picked a more reliable doc string change. All the integration tests are passing.
kdaily
pushed a commit
to kdaily/aws-cli
that referenced
this pull request
Apr 15, 2021
Update requires-dist to new syntax for setuptools
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that while there are no explicit tests in this PR for the
streaming output arg fix, there are in fact actually tests for this (both
unit and integration).
The problem was that we weren't checking the RC of the command that
was run, only that the request params looked how we wanted them to.
As a result, I've updated the
base test class to check for expected RCs from the commands that are
run. This caused the tests to fail and should ensure that if we
break the streaming output arg customization, we'll get a test failure.
I've also included a fix for an integration test. With this PR merged,
the integrations tests should finally be passing again (yay).