Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for streaming #1839

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

kyleknap
Copy link
Contributor

@kyleknap kyleknap commented Mar 7, 2016

Raise an error if the user tries to use --recursive

Fixes #1771

cc @jamesls @JordonPhillips

Raise an error if the user tries to use --recursive
@jamesls
Copy link
Member

jamesls commented Mar 7, 2016

:shipit:

kyleknap added a commit that referenced this pull request Mar 7, 2016
@kyleknap kyleknap merged commit 0db7fbd into aws:develop Mar 7, 2016
@davidwarshaw
Copy link
Contributor

Are the docs in this repo? It would be great if they were updated as well.

@kyleknap
Copy link
Contributor Author

kyleknap commented Mar 7, 2016

Depends, what part of the docs were you looking to get updated?

@davidwarshaw
Copy link
Contributor

I suggest a note in the entry for "Downloading a S3 object as a local file stream", indicating the recursive flag is not valid in combo:
http://docs.aws.amazon.com/cli/latest/reference/s3/cp.html

@davidwarshaw
Copy link
Contributor

While we're being thorough, it should be "Downloading an S3 object as a local file stream". :)

davidwarshaw pushed a commit to davidwarshaw/aws-cli that referenced this pull request Mar 8, 2016
davidwarshaw pushed a commit to davidwarshaw/aws-cli that referenced this pull request Mar 8, 2016
@davidwarshaw
Copy link
Contributor

PR for doc update here: /pull/1840

kyleknap added a commit that referenced this pull request Mar 8, 2016
jamesls pushed a commit that referenced this pull request Mar 8, 2016
* release-1.10.11:
  Bumping version to 1.10.11
  Update changelog with latest changes
  Update s3 cp docs re. /pull/1839
  Improve error message for streaming
  Update put-metric-alarm.rst
  Refactor Completer tests to use fake data
jamesls pushed a commit that referenced this pull request Mar 8, 2016
* release-1.10.11:
  Bumping version to 1.10.11
  Update changelog with latest changes
  Update s3 cp docs re. /pull/1839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants