Default ec2 page size to 1000 #1971
Conversation
| @@ -102,6 +103,7 @@ def awscli_initialize(event_handlers): | |||
| ec2_add_priv_launch_key) | |||
| register_parse_global_args(event_handlers) | |||
| register_pagination(event_handlers) | |||
| event_handlers.register('operation-args-parsed.ec2.*', set_max_results_default) | |||
There was a problem hiding this comment.
Should we be doing this for every ec2 operation? Does every ec2 operation have the "paginate and give me a pagination token only if you gave me a page size to start"?
There was a problem hiding this comment.
set_max_results checks if the function has pagination by looking for page_size, which is only present on functions that both have pagination enabled, and also have a limit key. At that point in the stack, I have no access to the pagination config so that's the only way to check. I could potentially manually compile a list of pagination operations, but then that would break whenever EC2 adds more.
|
Looks fine. Had a couple of questions though that I would like answered. |
JordonPhillips
force-pushed
the
ec2-pagination
branch
from
a21c6d9
to
812afc0
Compare
|
I rebased against develop since #1970 got merged. I also slightly simplified the if statement and clarified some of the logic. |
|
Hmm looks like you have some failing tests. |
|
Yeah, I think I may have messed up something when I rebased. |
jamesls
added
incorporating-feedback
and removed
pr:needs-review
If this value isn't set, EC2 will not paginate at all. Instead, they will attempt to return all values to you at once. Naturally, this can cause significant delay if you have a ton of resources.
JordonPhillips
force-pushed
the
ec2-pagination
branch
from
812afc0
to
63f89c1
Compare
|
I ended up not being able to use |
|
Change looks good to me. Looks like this is just pending a clean run through travis. |
JordonPhillips
added
pr:needs-review
|
👍 |
|
Makes sense to me. 🚢 |
If this value isn't set, EC2 will not paginate at all. Instead, they will
attempt to return all values to you at once. Naturally, this can cause
significant delay if you have a ton of resources.
Built off of #1970
cc @kyleknap @jamesls