-
Notifications
You must be signed in to change notification settings - Fork 4.5k
support AWS::Type::AppSync::FunctionConfiguration in artifact_exporter #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jfuss @justnance this patch should be ready for review. cheers! |
|
@jfuss @justnance sorry to be a pest, but any chance this could be reviewed and merged? thanks! |
|
@xentek I am not a maintainer of this repo and therefore have don't have control over commits. |
|
@sanathkr @justnance Just updated this PR with the latest from aws/aws-cli@develop. Any chance we can merge this soon so I don't have to continue to maintain and use my fork in my own workflow? Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #3883 +/- ##
===========================================
+ Coverage 94.44% 94.45% +<.01%
===========================================
Files 187 187
Lines 14071 14079 +8
===========================================
+ Hits 13290 13298 +8
Misses 781 781
Continue to review full report at Codecov.
|
kyleknap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me. Merging.
|
Is aws-package supports AppSync FunctionConfiguration? |
looks like this documentation needs to be updated if so: aws-cli/awscli/examples/cloudformation/_package_description.rst Lines 11 to 25 in 286d13a
related: #4029, aws-cloudformation/cfn-lint#608, aws-cloudformation/cfn-lint#1683, aws-cloudformation/cfn-lint#1684 |
Adds support to artifact_exporter for the new CloudFormation type
AWS::Type::AppSync::FunctionConfiguration(specifically theRequestMappingTemplateS3LocationResponseMappingTemplateS3Locationproperties).There was already an existing PR (#3822) but it hasn't seen any activity for over 25 days. This PR improves upon the original by adding tests for not only the
AppSyncFunctionConfigurationRequestTemplateResourceandAppSyncFunctionConfigurationResponseTemplateResourceclasses, which were introduced in this pull but also tests forAppSyncResolverRequestTemplateResourceandAppSyncResolverResponseTemplateResourcethat were introduced in a previous change.fixes #3816