Skip to content

support AWS::Type::AppSync::FunctionConfiguration in artifact_exporter #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleknap merged 3 commits into from
Feb 21, 2019
Merged

support AWS::Type::AppSync::FunctionConfiguration in artifact_exporter #3883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8f8f79
patches artifact_exporter to support AWS::Type::AppSync::FunctionConf…
xentek Jan 17, 2019
55f3eff
import classes
xentek Jan 23, 2019
591f683
Merge remote-tracking branch 'upstream/develop' into develop
xentek Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions awscli/customizations/cloudformation/artifact_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,22 @@ class AppSyncResolverResponseTemplateResource(Resource):
PACKAGE_NULL_PROPERTY = False


class AppSyncFunctionConfigurationRequestTemplateResource(Resource):
RESOURCE_TYPE = "AWS::AppSync::FunctionConfiguration"
PROPERTY_NAME = "RequestMappingTemplateS3Location"
# Don't package the directory if RequestMappingTemplateS3Location is omitted.
# Necessary to support RequestMappingTemplate
PACKAGE_NULL_PROPERTY = False


class AppSyncFunctionConfigurationResponseTemplateResource(Resource):
RESOURCE_TYPE = "AWS::AppSync::FunctionConfiguration"
PROPERTY_NAME = "ResponseMappingTemplateS3Location"
# Don't package the directory if ResponseMappingTemplateS3Location is omitted.
# Necessary to support ResponseMappingTemplate
PACKAGE_NULL_PROPERTY = False


class LambdaFunctionResource(ResourceWithS3UrlDict):
RESOURCE_TYPE = "AWS::Lambda::Function"
PROPERTY_NAME = "Code"
Expand Down Expand Up @@ -462,6 +478,8 @@ class ServerlessApplicationResource(CloudFormationStackResource):
GraphQLSchemaResource,
AppSyncResolverRequestTemplateResource,
AppSyncResolverResponseTemplateResource,
AppSyncFunctionConfigurationRequestTemplateResource,
AppSyncFunctionConfigurationResponseTemplateResource,
ApiGatewayRestApiResource,
LambdaFunctionResource,
ElasticBeanstalkApplicationVersion,
Expand Down
30 changes: 29 additions & 1 deletion tests/unit/customizations/cloudformation/test_artifact_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@
ServerlessApplicationResource, LambdaLayerVersionResource, \
copy_to_temp_dir, include_transform_export_handler, GLOBAL_EXPORT_DICT, \
ServerlessLayerVersionResource, ServerlessRepoApplicationLicense, \
ServerlessRepoApplicationReadme
ServerlessRepoApplicationReadme, \
AppSyncResolverRequestTemplateResource, \
AppSyncResolverResponseTemplateResource, \
AppSyncFunctionConfigurationRequestTemplateResource, \
AppSyncFunctionConfigurationResponseTemplateResource


def test_is_s3_url():
Expand Down Expand Up @@ -78,6 +82,26 @@ def test_all_resources_export():
"expected_result": uploaded_s3_url
},

{
"class": AppSyncResolverRequestTemplateResource,
"expected_result": uploaded_s3_url
},

{
"class": AppSyncResolverResponseTemplateResource,
"expected_result": uploaded_s3_url
},

{
"class": AppSyncFunctionConfigurationRequestTemplateResource,
"expected_result": uploaded_s3_url
},

{
"class": AppSyncFunctionConfigurationResponseTemplateResource,
"expected_result": uploaded_s3_url
},

{
"class": ApiGatewayRestApiResource,
"expected_result": {
Expand Down Expand Up @@ -112,6 +136,10 @@ def test_all_resources_export():
"class": ServerlessRepoApplicationReadme,
"expected_result": uploaded_s3_url
},
{
"class": ServerlessRepoApplicationLicense,
"expected_result": uploaded_s3_url
},
{
"class": ServerlessRepoApplicationLicense,
"expected_result": uploaded_s3_url
Expand Down