-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support update-kubeconfig during cluster update #4036
Support update-kubeconfig during cluster update #4036
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4036 +/- ##
========================================
Coverage 93.96% 93.96%
========================================
Files 188 188
Lines 14525 14525
========================================
Hits 13649 13649
Misses 876 876
Continue to review full report at Codecov.
|
Anything I can do to assist in getting this approved? |
How is it possible that this has languished since March? I can still reproduce this issue and it forces us to do some strange things to get around the issue. Can we get this merged? |
Happy to rebase this if there is hope of getting merged |
Upvote from me to merge, just ran into this error trying to deploy during an EKS update. Anything I/we can do to assist getting this approved? Thanks @coryflucas for fixing this! |
This seems to also be impacting the AWS CDK's EKS module (see #6279) |
@justnance can you look into this? |
I went ahead and rebased the change in case someone is able to look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Merging
Fixes #3914
Allows update-kubeconfig to run while cluster is either
ACTIVE
orUPDATING
. OnlyACTIVE
was supported currently. Presumably this is because theUPDATING
status did not exist when the functionality was added. I confirmed that all information required to build the kubeconfig is present in the DescribeCluster output while in theUPDATING
status.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.