Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update-kubeconfig during cluster update #4036

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Support update-kubeconfig during cluster update #4036

merged 1 commit into from
Jun 1, 2020

Conversation

coryflucas
Copy link
Contributor

Fixes #3914

Allows update-kubeconfig to run while cluster is either ACTIVE or UPDATING. Only ACTIVE was supported currently. Presumably this is because the UPDATING status did not exist when the functionality was added. I confirmed that all information required to build the kubeconfig is present in the DescribeCluster output while in the UPDATING status.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 31, 2019

Codecov Report

Merging #4036 into develop will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4036   +/-   ##
========================================
  Coverage    93.96%   93.96%           
========================================
  Files          188      188           
  Lines        14525    14525           
========================================
  Hits         13649    13649           
  Misses         876      876           
Impacted Files Coverage Δ
awscli/customizations/eks/update_kubeconfig.py 97.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661e470...4a58b8d. Read the comment docs.

@coryflucas
Copy link
Contributor Author

Anything I can do to assist in getting this approved?

@diranged
Copy link

How is it possible that this has languished since March? I can still reproduce this issue and it forces us to do some strange things to get around the issue. Can we get this merged?

@coryflucas
Copy link
Contributor Author

Happy to rebase this if there is hope of getting merged

@mparent61
Copy link

Upvote from me to merge, just ran into this error trying to deploy during an EKS update. Anything I/we can do to assist getting this approved?

Thanks @coryflucas for fixing this!

@eladb
Copy link

eladb commented Mar 10, 2020

This seems to also be impacting the AWS CDK's EKS module (see #6279)

@eladb
Copy link

eladb commented Mar 10, 2020

@justnance can you look into this?

@coryflucas
Copy link
Contributor Author

I went ahead and rebased the change in case someone is able to look at this

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging

@kyleknap kyleknap merged commit fe14153 into aws:develop Jun 1, 2020
@coryflucas coryflucas deleted the update-kubeconfig-during-upgrade branch June 2, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS update-config not working when updating cluster
7 participants