Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid format string in error message #4049

Closed
wants to merge 1 commit into from
Closed

Fix invalid format string in error message #4049

wants to merge 1 commit into from

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Apr 4, 2019

Description of changes:

Found using this PR of pyflakes: PyCQA/pyflakes#443

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #4049 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4049   +/-   ##
========================================
  Coverage    94.47%   94.47%           
========================================
  Files          187      187           
  Lines        14109    14109           
========================================
  Hits         13330    13330           
  Misses         779      779
Impacted Files Coverage Δ
awscli/topictags.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dab7c0...003d60c. Read the comment docs.

@asottile
Copy link
Contributor Author

@kyleknap this is an easy 1-character change that fixes a crash:

(for example)

>>> tag = topic_name = value = 1
>>> (
... 'Tag %s for topic %s has value %. Expected a single '
... 'element in list.' % (tag, topic_name, value)
... )
Traceback (most recent call last):
  File "<stdin>", line 3, in <module>
ValueError: unsupported format character ' ' (0x20) at index 32
>>> (
... 'Tag %s for topic %s has value %s. Expected a single '
... 'element in list.' % (tag, topic_name, value)
... )
'Tag 1 for topic 1 has value 1. Expected a single element in list.'

@asottile
Copy link
Contributor Author

@kyleknap @joguSD @stealthycoin any chance this can get merged? the programming error blocks an error message from appearing

@asottile asottile closed this Jan 29, 2020
@asottile asottile deleted the format_string branch January 29, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants