-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for Tagged Unions #7205
Conversation
e55927f
to
dd9acda
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7205 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 205 205
Lines 16424 16438 +14
==========================================
Hits 14 14
- Misses 16410 16424 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had a couple of suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Other than the comment on using the DenormalizedStructureBuilder
, just had one more comment. It also may be worth rebasing this off of develop. It looks like there may be some merge conflicts.
Auto-generate a note for Tagged Union structures in the docs that instructs users to only set one of the possible top level keys.
3927a67
to
15472bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚢
Services and
botocore
support Tagged Union structures. The purpose of this PR is to enhance the CLI docs by generating a usage note for Tagged Union structures. Because Tagged Union structures can be nested under other complex types, the change needed to be made for nested options, in addition to top level options.Preview of changes:
