Flatten CloudSearch arguments to make commandline use easier #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why these tests are failing since they work for me. @jamesls, could it be related to CloudSearch being in preview? |
|
Does it fail if you disable cloudsearch locally in your config? |
|
That's funny I was just trying that right now. It does. I'm looking into how to enable it on a per-test basis, or alternatively do you have any ideas on how to handle these cases? |
|
Well, this PR should be taking cloudsearch out of preview, so let's just review cloudsearch from the preview list. |
|
|
Looks good. Would you also mind adding something to the CHANGELOG.rst when you merge this?
* Updated documentation * FlattenCommands -> FlattenArguments * modify_args -> flatten_args, _find_nested_arg, _merge_member_config * service -> service_name * CLI registration is separated from object instantiation now * AssertIn for tests * Added a test for list types * Added type to FlattenedArgument * Fix CloudSearch argument hydrating to use correct types * Some refactoring
danielgtaylor
added a commit
that referenced
this pull request
Apr 1, 2014
Move CloudSearch out of preview. Fixes #730. Adds customizations to make using CloudSearch easier from the commandline.
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Update README.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic mechanism to flatten command arguments and rehydrate those values. Adds tests for this new mechanism and the CloudSearch-specific features. In the future this can be used to migrate existing flattening code (e.g. EC2 customizations).
@jamesls please review.