Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON only when getting user entries in kubeconfig #7726

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

yuxiang-zhang
Copy link
Contributor

@yuxiang-zhang yuxiang-zhang commented Mar 6, 2023

Issue #, if available:
#7719, #7723, #7724

Description of changes:
Hard-code json as the output format when getting user entry in kubeconfig.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yuxiang-zhang yuxiang-zhang force-pushed the get-token-json-output branch from a48302a to 4d68e79 Compare March 6, 2023 20:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #7726 (ba2f1ec) into develop (8582913) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #7726      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          206     206              
  Lines        16486   16488       +2     
==========================================
  Hits            14      14              
- Misses       16472   16474       +2     
Impacted Files Coverage Δ
awscli/customizations/eks/get_token.py 0.00% <0.00%> (ø)
awscli/customizations/eks/update_kubeconfig.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yuxiang-zhang yuxiang-zhang changed the title Use JSON only for get-token output Use JSON only when getting user entries in kubeconfig Mar 6, 2023
@tim-finnigan
Copy link
Contributor

@yuxiang-zhang or @stealthycoin can we get your thoughts on this comment: #7719 (comment) ?

I'm not sure this is a complete fix then. New (greenfield) users would be covered, but anyone would else would still have this issue. Since the error message doesn't give any hints on cause they would have to search around, find this issue, and then apply fixes themselves. Unless I'm misunderstanding something.

I would classify this as still open.

Suggestion: Ignore user-set formatting variables when not in an interactive tty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants