Add support for square bracket shorthand lists #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -245,7 +245,7 @@ def _list_scalar_list_parse(self, param, value): | |||
| current_value = unpack_scalar_cli_arg(args[current_key], | |||
| current[1].strip()) | |||
| if args[current_key].type == 'list': | |||
| current_parsed[current_key] = [current_value] | |||
| current_parsed[current_key] = current_value.split(',') | |||
There was a problem hiding this comment.
It would be good to add a test for this too, to verify we actually parse the final shorthand value into a list.
|
Looks good, just would like a test for the shorthand change. |
|
|
Looks good.
danielgtaylor
added a commit
that referenced
this pull request
May 23, 2014
Add support for square bracket shorthand lists. Fixes #788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a new shorthand list syntax. See examples in
test_utils.py.@jamesls please review.