Fix single item shorthand list parsing bug #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where shorthand lists made with `[` and `]` containing only a single item would not be parsed correctly. The `_eat_items` utility function did not take into account the fact that the list end character could be in the first item. I've added a conditional to check for this case and not call the `_eat_items` method, because the current behavior is expected for some inputs that use `_eat_items`.
|
|
Looks good. Please be sure to add an entry to the CHANGELOG.rst before pushing to develop.
danielgtaylor
added a commit
that referenced
this pull request
Jun 30, 2014
Fix single item shorthand list parsing bug. Fixes #830.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where shorthand lists made with
[and]containing onlya single item would not be parsed correctly. The
_eat_itemsutility functiondid not take into account the fact that the list end character could be in the
first item. I've added a conditional to check for this case and not call
the
_eat_itemsmethod, because the current behavior is expected for someinputs that use
_eat_items.cc @jamesls