Skip to content

Add another example for cognito-idp update-user-pool #8358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Nov 23, 2023

Description of changes:

The aws cognito-idp update-user-pool command can reset certain attributes of a user pool, so I've added an example of how to avoid that.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tim-finnigan
Copy link
Contributor

Thanks for creating this PR, I think we'll want to check in with someone from the Cognito team to review this.

Link to docs for reference: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/cognito-idp/update-user-pool.html#examples

I wasn't sure what the "As mentioned earlier," wording you added was referring to, but I think it's this warning:

image

This behavior is also explained more in the Cognito Developer Guide: https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-updating.html#cognito-user-pool-updating-api-cli

@kdnakt
Copy link
Contributor Author

kdnakt commented Jul 6, 2024

Yes, the "As mentioned earlier," wording refers to the warning.

I thought my change clarifies the explanation in the developer guide.

@elysahall elysahall self-requested a review December 10, 2024 18:05
@elysahall elysahall self-assigned this Dec 10, 2024
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Dec 10, 2024
@elysahall
Copy link
Collaborator

Hi @kdnakt,
Thank you for your example submission! Since you submitted this PR, the example file has gone through significant updates. Please review if these updates address the changes you were making, and if not, update your PR to resolve conflicts.

Thanks.

@elysahall elysahall removed their assignment Jan 22, 2025
@kdnakt
Copy link
Contributor Author

kdnakt commented Jan 22, 2025

Okay I'll review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants