[v2] s3: Handle unlinked current working directory #8939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fatal error: [Errno 2] No such file or directory
when run from cloud-init runcmd #7143Description of changes:
The
relative_path
function can also fail on Unix-like systems if the current working directory has been unlinked.Add this except block next to already existing one for Windows systems where different drives might be in use.
Proof of Concept:
You can see the following output:
If you analyze the
aws
call withstrace
, you can see that actuallygetcwd
fails and that the error message is not about/bin/ls
at all:With this patch applied,
aws
continues operation and just prints the absolute path instead of relative one.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.