add examples for CloudWatch CLI commands #9038
Conversation
elysahall
added
the
pr:work-in-progress
elysahall
added
pr:needs-review
| @@ -0,0 +1,34 @@ | |||
| **To create a contributor insights rule** | |||
|
|
|||
| The following ``put-insight-rule`` example creates a Contributor Insights rule named ``VPCFlowLogsContributorInsights`` in the specified account. If the command succeeds, no output is returned. :: | |||
There was a problem hiding this comment.
nit: Usually the comment that there is no output is after the command with the text "This command produces no output."
There was a problem hiding this comment.
Updated the suggestion.
chaitanyagummadi
force-pushed
the
cloudwatch-cli-docs-v3
branch
from
4f7ff5f
to
a5458df
Compare
|
I will port this to the v2 branch before merging. |
| @@ -0,0 +1,17 @@ | |||
| **To create a metric stream** | |||
|
|
|||
| The following ``put-metric-stream`` example creates a metric stream named ``QuickFull-GuaFb`` in the specified account. :: | |||
There was a problem hiding this comment.
Maybe an extra space between the . and the ::.
There was a problem hiding this comment.
Confirmed that only 1 space here
| --output-format json \ | ||
| --no-include-linked-accounts-metrics | ||
|
|
||
| Output:: |
There was a problem hiding this comment.
Missing a newline here:
| Output:: | |
| Output:: | |
There was a problem hiding this comment.
I think this is causing a couple of the tests failures. Let's resolve this one and I'll check the tests again.
There was a problem hiding this comment.
Added new line in the last commit.
* fix the 2 examples * fix the put-metric-stream API
chaitanyagummadi
force-pushed
the
cloudwatch-cli-docs-v3
branch
from
2b71103
to
4304c48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9038 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 210 210
Lines 16952 16978 +26
==========================================
Hits 14 14
- Misses 16938 16964 +26 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Issue #, if available:
Description of changes:
Adding example CLI commands for Amazon CloudWatch: https://docs.aws.amazon.com/cli/latest/reference/cloudwatch/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.