Skip to content

Fix non-deterministic S3 test failure. #9069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Nov 11, 2024

Description of changes:

  • Replace a hard-coded part number with mock.ANY to prevent non-deterministic test failures.

Description of tests:

  • Ran the updates test locally and observed it passes.

Relevant links:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested review from aws-sdk-python-automation and a team November 11, 2024 18:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.08%. Comparing base (52985a2) to head (f216d4a).
Report is 72 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #9069      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16952   16955       +3     
==========================================
  Hits            14      14              
- Misses       16938   16941       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateprewitt nateprewitt self-requested a review November 11, 2024 19:09
@aemous aemous merged commit 6a54374 into aws:develop Nov 11, 2024
30 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Nov 12, 2024
* release-1.36.0:
  Bumping version to 1.36.0
  Update changelog based on model updates
  Enable support for loading files into nested parameter values (#9063)
  Fix non-deterministic S3 test failure. (#9069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants