Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example outputs for ECS update-service command #9080

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

nambinayagan
Copy link

Issue #, if available:

Description of changes:
Added outputs for example commands and corrected the documentation link since previous link was redirecting to ECS Welcome page.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added example outputs and --cluster since without --cluster the command with service name will only check for default cluster
Added Active Taskdefinition part for better understanding.
Corrected the documentation link as previous link was redirecting to Welcome page in ECS documentation
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Nov 20, 2024
@elysahall elysahall self-requested a review November 20, 2024 17:03
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nambi,
There were a few formatting issues. Please accept the suggested changes, then this PR will be ready for maintainer review.


aws ecs update-service --service my-http-service --task-definition amazon-ecs-sample
aws ecs update-service --service my-http-service --cluster my-cluster --task-definition amazon-ecs-sample
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aws ecs update-service --service my-http-service --cluster my-cluster --task-definition amazon-ecs-sample
aws ecs update-service \
--service my-http-service \
--cluster my-cluster \
--task-definition amazon-ecs-sample

@@ -1,13 +1,173 @@
**Example 1: To change the task definition used in a service**

The following ``update-service`` example updates the ``my-http-service`` service to use the ``amazon-ecs-sample`` task definition. ::
The following ``update-service`` example updates the ``my-http-service`` service present in ``my-cluster`` cluster to use the latest ``ACTIVE`` revision of ``amazon-ecs-sample`` task definition. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following ``update-service`` example updates the ``my-http-service`` service present in ``my-cluster`` cluster to use the latest ``ACTIVE`` revision of ``amazon-ecs-sample`` task definition. ::
The following ``update-service`` example updates the ``my-http-service`` service present in the ``my-cluster`` cluster to use the latest ``ACTIVE`` revision of ``amazon-ecs-sample`` task definition. ::

"propagateTags": "NONE",
"enableExecuteCommand": false
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information, see `Updating a Service <https://docs.aws.amazon.com/AmazonECS/latest/developerguide/update-service-console-v2.html>`__ in the *Amazon ECS Developer Guide*.

For more information, see `Updating a Service <https://docs.aws.amazon.com/AmazonECS/latest/developerguide/update-service-console-v2.html>`_ in the *Amazon ECS Developer Guide*.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information, see `Updating a Service <https://docs.aws.amazon.com/AmazonECS/latest/developerguide/update-service-console-v2.html>`_ in the *Amazon ECS Developer Guide*.
For more information, see `Updating a Service <https://docs.aws.amazon.com/AmazonECS/latest/developerguide/update-service-console-v2.html>`__ in the *Amazon ECS Developer Guide*.

The following ``update-service`` example updates the desired task count of the service ``my-http-service`` to 3. ::
The following ``update-service`` example updates the desired task count of the service ``my-http-service`` present in ``my-cluster`` cluster to 3. ::

aws ecs update-service --service my-http-service --cluster my-cluster --desired-count 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aws ecs update-service --service my-http-service --cluster my-cluster --desired-count 3
aws ecs update-service \
--service my-http-service \
--cluster my-cluster \
--desired-count 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants