-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[Documentation] Warning against the use of S3 Global Endpoint (s3.amazonaws.com) as endpoint-url #9850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
Add warning to S3 configuration documentation advising users to avoid using s3.amazonaws.com as the --endpoint-url parameter value to prevent PermanentRedirect errors and configuration confusion. This addresses user issues where setting the global S3 endpoint as a custom endpoint URL causes redirect loops and unexpected behavior. Addresses aws#9479
Add warning to S3 configuration docs advising against using the global S3 endpoint (s3.amazonaws.com) as --endpoint-url parameter value to prevent PermanentRedirect errors and other unwanted behaviors/errors from S3 Addresses aws#9479
awscli/topics/s3-config.rst
Outdated
| for performance reasons or to account for the specific environment where these | ||
| ``aws s3`` commands are being run. | ||
|
|
||
| .. warning:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this into the "Configuration Values" section as a general comment, not a warning.
awscli/topics/s3-config.rst
Outdated
|
|
||
| .. warning:: | ||
| S3 commands have a parameter ``--endpoint-url`` that overrides the command's | ||
| default URL with the given URL. Avoid using the S3 Global Endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could be a bit more general here and just say you should avoid configuring the endpoint URL at all when using the AWS S3 service? Generally endpoint URL is only going to be needed for 3P endpoints when using S3.
|
This might be a good place to point customers to: https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html |
Move endpoint-url warning from warning block to note format and relocate to appropriate section based on code review feedback. Add reference to AWS service-specific endpoints documentation. Addresses aws#9479 Refactor the S3 endpoint-url guidance based on review feedback: - Change from warning block to note format - Add reference to official AWS service-specific endpoints guide - Improve clarity of when to use endpoint-url with appropriate actions - Maintain focus on preventing redirect issues and unintended behavior This addresses the original issue while incorporating reviewer suggestions for better placement and formatting of the guidance.
Improved clarity and readability of the endpoint_url parameter documentation for S3 commands.
Summary
Adds documentation improvements to S3 configuration documentation (in the AWS CLI) for the --endpoint-url parameter:
Warning against S3 Global endpoint: Advises users to avoid using
https://s3.amazonaws.comorhttp://s3.amazonaws.comas the --endpoint-url parameter value, as it can cause PermanentRedirect errors and configuration confusion.General endpoint_url guidance: Adds a note explaining the --endpoint-url parameter usage, including caution about S3 unintended behavior such as S3 redirect issues. References the AWS SDK reference guide for additional endpoint configuration information.
Testing
• [x] Documentation builds successfully with make html
• [x] Warning and note display correctly in generated docs
Addresses #9479