Skip to content

Conversation

@lauzadis
Copy link
Member

@lauzadis lauzadis commented Apr 3, 2024

Fixes iOS simulator TLS negotiation errors by disabling standalone mode in simulator tests. The root cause is not known, but disabling standalone fixes the TLS issues. https://youtrack.jetbrains.com/issue/KT-38317.

Disabling standalone means we need to manage the simulator ourselves. This is done by registering new Gradle tasks to boot and shutdown the simulator when needed.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lauzadis lauzadis requested a review from a team as a code owner April 3, 2024 15:06
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Apr 3, 2024
Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job finding a workaround

Copy link
Contributor

@0marperez 0marperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: the windows and linux CI fail when trying to boot the IOS simulator device, is there an unrelated reason or is this expected?

@lauzadis
Copy link
Member Author

lauzadis commented Apr 3, 2024

Question: the windows and linux CI fail when trying to boot the IOS simulator device, is there an unrelated reason or is this expected?

It's an issue and shouldn't be happening, working on a fix now 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lauzadis lauzadis merged commit 4b10e82 into kn-main Apr 3, 2024
@lauzadis lauzadis deleted the kn-fix-ios-tls branch April 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants