Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(java): set MPL version in build.gradle.kts from project.properties #1268

Merged
merged 4 commits into from
Feb 1, 2025
Merged

chore(java): set MPL version in build.gradle.kts from project.properties #1268

merged 4 commits into from
Feb 1, 2025
+6 −21

Conversation

RitvikKapila
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RitvikKapila RitvikKapila requested a review from a team as a code owner January 30, 2025 23:31
@RitvikKapila RitvikKapila changed the title chore(java): set MPL version in build.gradle.kts from project.properties chore(java;python): set MPL version in build.gradle.kts from project.properties; update python polymorph code Jan 31, 2025
josecorella
josecorella previously approved these changes Jan 31, 2025
View reviewed changes
texastony
texastony reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check how the semantic release job handles these?

@texastony
Copy link
Contributor

Did you check how the semantic release job handles these?

https://github.com/aws/aws-cryptographic-material-providers-library/blob/main/.releaserc.cjs

This is the file that configures the behavior of the semantic release action.

@RitvikKapila RitvikKapila changed the title chore(java;python): set MPL version in build.gradle.kts from project.properties; update python polymorph code chore(java): set MPL version in build.gradle.kts from project.properties Jan 31, 2025
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

josecorella
josecorella previously approved these changes Jan 31, 2025
View reviewed changes
@RitvikKapila RitvikKapila force-pushed the rkapila/fix-java-releases branch from 51ccca1 to ef1b921 Compare January 31, 2025 23:49
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@RitvikKapila RitvikKapila merged commit 7383f05 into main Feb 1, 2025
339 of 392 checks passed
@RitvikKapila RitvikKapila deleted the rkapila/fix-java-releases branch February 1, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texastony texastony texastony left review comments

@josecorella josecorella josecorella approved these changes

@ShubhamChaturvedi7 ShubhamChaturvedi7 ShubhamChaturvedi7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RitvikKapila @texastony @ShubhamChaturvedi7 @josecorella