Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Partial fixes to nightly build #1277

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Conversation

robin-aws
Copy link
Contributor

  • Fix several typos in the workflow files
  • Always --recursive when initializing the smithy-dafny submodule
  • Use nightly-latest for Rust as well now that everything it needs is in Dafny master

Dry run on Manual CI: https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/13094156906. Gets much further, although there are still verification failures to fix and segmentation faults for some reason.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@robin-aws robin-aws requested a review from a team as a code owner February 3, 2025 17:18
…ryptographic-material-providers-library-dafny into robin-aws/build-fix-2025-01-07
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robin-aws robin-aws merged commit ce2d4ba into main Feb 3, 2025
196 checks passed
@robin-aws robin-aws deleted the robin-aws/build-fix-2025-01-07 branch February 3, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants