Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repr=False to attributes in EncryptionContext #127

Closed
johnwalker opened this issue Oct 3, 2019 · 0 comments · Fixed by #128
Closed

Add repr=False to attributes in EncryptionContext #127

johnwalker opened this issue Oct 3, 2019 · 0 comments · Fixed by #128
Assignees
@mattsb42-aws
Labels
bug

Comments

@johnwalker
Copy link
Contributor

johnwalker commented Oct 3, 2019 •
edited
Loading

https://github.com/aws/aws-dynamodb-encryption-python/blob/master/src/dynamodb_encryption_sdk/structures.py#L49-L78

We should add repr=False to the attributes section in the EncryptionContext, to make the string representation safe within material providers. This is useful particularly in the context of logging.

Similar to aws/aws-dynamodb-encryption-java#100
@johnwalker johnwalker changed the title Add repr=False to attributeValues in EncryptionContext Add repr=False to attributes in EncryptionContext Oct 3, 2019
@mattsb42-aws mattsb42-aws self-assigned this Oct 3, 2019
@mattsb42-aws mattsb42-aws mentioned this issue Oct 3, 2019
Merged
1 task
mattsb42-aws added a commit that referenced this issue Oct 3, 2019
@mattsb42-aws
Remove "attributes" from EncryptionContext str/repr (#128)
4374ad5 
* add test to verify that EncryptionContext.attributes is not included in str/repr

* remove EncryptionContext.attributes from str/repr

* update changelog with #127 fix

* add pylint ignores for no-member checks on generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsb42-aws mattsb42-aws

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "attributes" from EncryptionContext str/repr
2 participants
@johnwalker @mattsb42-aws