Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MostRecentProvider._get_most_recent_version does not return the correct value if the lock cannot be acquired #72

Closed
mattsb42-aws opened this issue May 14, 2018 · 0 comments
Assignees
Labels

Comments

@mattsb42-aws
Copy link
Member

_get_most_recent_version used to return a tuple of the version and the provider. We changed that at some point to only return a provider, but we apparently missed updating the branch taken if the lock cannot be acquired.

https://github.com/awslabs/aws-dynamodb-encryption-python/blob/master/src/dynamodb_encryption_sdk/material_providers/most_recent.py#L245-L250

@mattsb42-aws mattsb42-aws self-assigned this May 14, 2018
@mattsb42-aws mattsb42-aws changed the title _get_most_recent_version does not return the correct value if the lock cannot be acquired MostRecentProvider._get_most_recent_version does not return the correct value if the lock cannot be acquired May 14, 2018
lizroth added a commit that referenced this issue May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant