Skip to content

Fix EncryptedPaginator to successfully decrypt #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 28, 2019
Merged

Fix EncryptedPaginator to successfully decrypt #120

merged 10 commits into from
Aug 28, 2019

Conversation

mattsb42-aws
Copy link
Member

Issue #, if available:
#118

Description of changes:

  • Added integration tests that test the scan paginator with KMS crypto materials providers.
  • Single-sourced logic for decrypting a list of items, and updated both EncryptedPaginator and decrypt_multi_get to use it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@mattsb42-aws mattsb42-aws requested a review from a team August 27, 2019 02:28
@mattsb42-aws mattsb42-aws changed the title Query Fix EncryptedPaginator to successfully decrypt Aug 27, 2019
ragona
ragona previously approved these changes Aug 27, 2019
Copy link

@ragona ragona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SalusaSecondus
Copy link
Contributor

LGTM, with the following two comments:

  1. I'm not a python dev.
  2. Please add a specific regression test to the non-integration tests to catch this specific bug (or more generally if possible)

@mattsb42-aws
Copy link
Member Author

LGTM, with the following two comments:

2. Please add a specific regression test to the non-integration tests to catch this specific bug (or more generally if possible)

Added.
I also verified that these test changes break the EncryptedPaginator tests as expected if the other changes in this PR are not applied.

@mattsb42-aws mattsb42-aws merged commit 643460e into aws:master Aug 28, 2019
@mattsb42-aws mattsb42-aws deleted the query branch August 28, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants