docs: added guidance on how to setup acm private ca for istio #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mesh Signed-off-by: Lukonde Mwila <outlier.developer@gmail.com>
chrisnegus
reviewed
Feb 20, 2023
content/security/docs/network.md
Outdated
|
|
||
|
|
||
| #### Setup Instructions | ||
| 1. Start by following the same [setup instructions](https://aws.github.io/aws-eks-best-practices/security/docs/network/#setup-instructions) outlined above to complete the following: |
There was a problem hiding this comment.
Just an FYI, not required for you to do here: Instead of numbering each step "1.", "2.", "3." and so on, you can number each step "1." As long as you indent any sub-bullets or code blocks three spaces, each step will number sequentially. In the future, if you ever need to insert a step in the middle, you don't have to go through and renumber everything.
There was a problem hiding this comment.
Sure thing. Thanks @chrisnegus
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added guidance on how to set up ACM Private CA as the root CA for Istio in an EKS cluster.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.