Fix a bug where framefmt serialize returns a wrong ciphertext size #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@david-koenig @ttjsu-aws could you review this PR? |
There was a problem hiding this comment.
Made one comment for a slight improvement on this test. It looks like the tests are passing on non-Windows platforms, so I'm guessing that the only reason this is failing is because of the separate Windows build issue. Provided you make the one change I've recommended, I'm fine with this code change and will approve. But the Windows build issue still needs to be fixed first in order to get this PR to pass CI and be merged.
…erialize is called
david-koenig
approved these changes
Jul 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug found in #378 and add a unit test to exercise it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.