Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended RSA padding mode #522

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Use recommended RSA padding mode #522

merged 2 commits into from
Mar 2, 2022

Conversation

juneb
Copy link
Contributor

@juneb juneb commented May 12, 2020

Issue #, if available:

Description of changes:
Changing the example to use the recommend OAEP padding mode. We discourage the use of the PKCS#1 padding mode. It's included only for backwards compatibility.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

seebees
seebees previously approved these changes May 22, 2020
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smswz smswz requested a review from a team as a code owner March 1, 2022 19:02
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is reformatting and then switching the RSA padding scheme.

@smswz smswz merged commit be9c825 into aws:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants