Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing library to compilation example #697

Merged
merged 2 commits into from
May 5, 2022
Merged

Add missing library to compilation example #697

merged 2 commits into from
May 5, 2022

Conversation

rendon
Copy link
Contributor

@rendon rendon commented Apr 22, 2021

Issue #, if available:

Description of changes: The example to compile standalone C++ programs is missing a library (-laws-crt-cpp), at least on Ubuntu.

The next snippet shows what happens when you run the command provided in the README.

$ g++ -o string string.cpp -std=c++11 -lcrypto -laws-encryption-sdk
 -laws-encryption-sdk-cpp -laws-c-common -laws-cpp-sdk-kms -laws-cpp-sdk-core
/usr/bin/ld: /tmp/cciWoA8n.o: undefined reference to symbol '_ZN3Aws3Crt11g_allocatorE'
//usr/local/lib/libaws-crt-cpp.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony
Copy link
Contributor

texastony commented Jun 7, 2021

Howdy rendon,

Thank you for bringing up this compilation issue.

Could you help me recreate the compile error you encountered by replying with the commands you used to install the dependencies and the Encryption SDK (ESDK) for C? What versions did you install?

I am curious if you installed the entire AWS SDK for C or just the KMS portion. Did you install aws-c-common separately from the SDK?

Much Obliged,
AWS Crypto Tools

@texastony texastony requested a review from a team as a code owner May 3, 2022 17:52
@alex-chew alex-chew merged commit 0a19156 into aws:master May 5, 2022
@rendon
Copy link
Contributor Author

rendon commented May 5, 2022

Cool, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants