Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore bump openssl #746

Merged
merged 4 commits into from
May 2, 2022
Merged

Chore bump openssl #746

merged 4 commits into from
May 2, 2022

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony texastony requested a review from a team as a code owner May 2, 2022 02:09
@texastony texastony temporarily deployed to continuous-integration May 2, 2022 02:09 Inactive
@texastony texastony temporarily deployed to continuous-integration May 2, 2022 02:09 Inactive
@texastony
Copy link
Contributor Author

texastony commented May 2, 2022

CodeBuild target build_test_static_valgrind failed,
which is part of the batch build check,
AWS CodeBuild BuildBatch us-west-2 (csdk-ubuntu-latest-x64) .

It appears that the tests or test environment is incorrectly configured.
There are many errors like:

[WARN] 2022-05-02 02:13:12.816 AWSErrorMarshaller [140391237241920] Encountered AWSError 'IncorrectKeyException': The key ID in the request does not identify a CMK that can perform this operation.

Or

[ERROR] 2022-05-02 02:13:12.783 KmsMrkAwareSymmetricKeyring [140391237241920] Could not find any data key that can be decrypted by KMS. Errors:Error: Malformed ciphertext. Provider ID field of KMS EDK is invalid KMS CMK ARN: arn::kms:us-west-2:658956600833:key/mrk-80bd8ecdcd4342aebd84b7dc9da498a7

Or

Failed to initialize aws_cryptosdk_kms_keyring, An invalid argument was passed to a function.

It looks like the test may have been throttled by AWS,
these were encountered while calling STS and SSO for retrieving credentials:

[DEBUG] 2022-05-02 02:11:51.984 CURL [140391237241920] (DataIn) You have reached maximum request limit.
...
[DEBUG] 2022-05-02 02:11:51.984 CurlHttpClient [140391237241920] Returned http response code 429

They were followed by errors from KMS:

[DEBUG] 2022-05-02 02:11:52.005 CURL [140391237241920] (HeaderIn) HTTP/1.1 400 Bad Request
...
[DEBUG] 2022-05-02 02:11:52.006 CURL [140391237241920] (DataIn) {
    "__type": "MissingAuthenticationTokenException",
    "message": "Missing Authentication Token"
}

A subsequent call to retrieve credentials succeeded. That was followed by successful KMS calls.

@texastony
Copy link
Contributor Author

Operating under the assumption that the
batch build failed due to IAM/SSO/STS throtteling,
I have re-submitted the failed build.

@texastony
Copy link
Contributor Author

texastony commented May 2, 2022

Ok. Re-submitting the failed build worked.

I checked the Batch Build logs.
All 4 builds are executed in parallel.
Which, in combination with the three other CodeBuild executions, may exceed our IAM/STS/SSO capacity.

There are several possible fixes:

  1. Request more IAM/STS/SSO capacity (probably STS).
  2. Execute the Batch Build serially, instead of all at once.

That list is not conclusive, but is a good starting point.

@texastony texastony temporarily deployed to continuous-integration May 2, 2022 20:39 Inactive
@texastony texastony temporarily deployed to continuous-integration May 2, 2022 20:39 Inactive
@texastony texastony temporarily deployed to continuous-integration May 2, 2022 20:39 Inactive
@texastony texastony temporarily deployed to continuous-integration May 2, 2022 20:39 Inactive
@texastony texastony merged commit 7a3f79e into master May 2, 2022
@texastony texastony deleted the chore-bump-openssl branch May 2, 2022 21:49
@texastony texastony mentioned this pull request May 3, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants