Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize buffer in cipher_openssl.c #751

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:
#749

Description of changes:
Initialize the uninitialized buffer. It will cost a few instructions, but it's not in a tight loop.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@ajewellamz ajewellamz requested a review from a team as a code owner July 14, 2022 12:52
@ajewellamz ajewellamz temporarily deployed to continuous-integration July 14, 2022 12:52 Inactive
@ajewellamz ajewellamz temporarily deployed to continuous-integration July 14, 2022 12:52 Inactive
@ajewellamz ajewellamz requested a review from alex-chew July 14, 2022 12:53
@alex-chew alex-chew changed the title Update cipher_openssl.c fix: initialize buffer in cipher_openssl.c Jul 14, 2022
@alex-chew
Copy link
Contributor

I'm going ahead and merging this despite the two failing checks. The csdk-ubuntu-latest-x64-awslc check will fail until we merge #750, which in turn depends (functionally) on this PR. And it's safe to ignore the Semantic PR check since I'll fix up the squash commit message.

@alex-chew alex-chew merged commit c61d536 into master Jul 14, 2022
@ajewellamz ajewellamz deleted the ajewellamz-patch-1 branch January 30, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants