Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out-of-bounds constant in default_cmm.c #752

Merged
merged 6 commits into from
Aug 26, 2022
Merged

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:
#688

Description of changes:
Given the value in the aws_cryptosdk_alg_id enum, the compiler could use 'signed short' as the underlying data type. 0xFFFF, implicitly cast to an integer, cannot fit in a signed short, but 0x7FFF can.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@ajewellamz ajewellamz requested a review from a team as a code owner July 14, 2022 12:56
@ajewellamz ajewellamz temporarily deployed to continuous-integration July 14, 2022 12:56 Inactive
@ajewellamz ajewellamz temporarily deployed to continuous-integration July 14, 2022 12:56 Inactive
@ajewellamz ajewellamz requested a review from alex-chew July 14, 2022 12:56
@alex-chew alex-chew temporarily deployed to continuous-integration July 14, 2022 18:06 Inactive
@alex-chew alex-chew temporarily deployed to continuous-integration July 14, 2022 18:06 Inactive
@alex-chew alex-chew temporarily deployed to continuous-integration July 14, 2022 18:06 Inactive
@alex-chew alex-chew temporarily deployed to continuous-integration July 14, 2022 18:06 Inactive
@alex-chew alex-chew changed the title Update default_cmm.c fix: out-of-bounds constant in default_cmm.c Jul 14, 2022
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 25, 2022 17:12 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 25, 2022 17:12 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 25, 2022 17:12 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 25, 2022 17:12 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 14:10 Error
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 14:10 Inactive
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 14:10 Error
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 14:10 Inactive
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 14:37 Error
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 14:37 Inactive
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 14:38 Error
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 14:38 Inactive
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 14:39 Error
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 14:39 Inactive
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 15:29 Error
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 15:29 Inactive
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 17:39 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 17:39 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 17:39 Failure
@ajewellamz ajewellamz had a problem deploying to continuous-integration August 26, 2022 17:39 Failure
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 17:43 Inactive
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 17:43 Inactive
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 17:43 Inactive
@ajewellamz ajewellamz temporarily deployed to continuous-integration August 26, 2022 17:43 Inactive
@ajewellamz ajewellamz merged commit 85c892c into master Aug 26, 2022
@ajewellamz ajewellamz deleted the ajewellamz-patch-2 branch August 26, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants