Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CBMC proof-running GitHub Action #763

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

karkhaz
Copy link
Contributor

@karkhaz karkhaz commented Feb 17, 2023

This commit adds a GitHub Action that runs the CBMC proofs upon every push and pull request. This is intended to replace the current CBMC CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@karkhaz karkhaz had a problem deploying to continuous-integration February 17, 2023 14:41 — with GitHub Actions Failure
@karkhaz karkhaz had a problem deploying to continuous-integration February 17, 2023 14:41 — with GitHub Actions Error
@karkhaz karkhaz force-pushed the kk-add-cbmc-github-action branch from 0e70f3b to c9e67c9 Compare February 17, 2023 15:43
@karkhaz karkhaz marked this pull request as ready for review February 17, 2023 17:17
@karkhaz karkhaz requested a review from a team as a code owner February 17, 2023 17:17
@karkhaz
Copy link
Contributor Author

karkhaz commented Feb 17, 2023

You can see the new run_cbmc_proofs Action that this introduces in the status box below, here's a link to the successful proof run

@feliperodri feliperodri added the cbmc CBMC proof related work label Feb 17, 2023
feliperodri
feliperodri previously approved these changes Feb 17, 2023
Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @karkhaz!

@karkhaz karkhaz had a problem deploying to continuous-integration February 20, 2023 19:39 — with GitHub Actions Error
@karkhaz karkhaz had a problem deploying to continuous-integration February 20, 2023 19:39 — with GitHub Actions Failure
@texastony
Copy link
Contributor

I approved the deployment of the MacOS tests:
https://github.com/aws/aws-encryption-sdk-c/actions/runs/4205285088/jobs/7297139197

I do not have time to look into the CodeBuild failures:
https://us-west-2.console.aws.amazon.com/codebuild/home?region=us-west-2#/builds/build-batch/csdk-ubuntu-latest-x64:f4d3ec89-d08e-47f5-9f78-09e061b5bebf/view/new

Hopefully I or someone else on my team can look into them later this week.

@ajewellamz ajewellamz changed the title Add CBMC proof-running GitHub Action feat: Add CBMC proof-running GitHub Action Feb 27, 2023
@karkhaz karkhaz force-pushed the kk-add-cbmc-github-action branch from c9e67c9 to fb8e62c Compare March 3, 2023 15:25
@karkhaz karkhaz temporarily deployed to continuous-integration March 3, 2023 18:41 — with GitHub Actions Inactive
@karkhaz karkhaz temporarily deployed to continuous-integration March 3, 2023 18:41 — with GitHub Actions Inactive
@karkhaz karkhaz force-pushed the kk-add-cbmc-github-action branch 3 times, most recently from f867ce1 to dc4edfb Compare March 6, 2023 23:35
This commit adds a GitHub Action that runs the CBMC proofs upon every
push and pull request. This is intended to replace the current CBMC CI.
@karkhaz karkhaz force-pushed the kk-add-cbmc-github-action branch from dc4edfb to 0661e00 Compare March 6, 2023 23:37
@karkhaz karkhaz temporarily deployed to continuous-integration March 7, 2023 00:09 — with GitHub Actions Inactive
@karkhaz karkhaz temporarily deployed to continuous-integration March 7, 2023 00:09 — with GitHub Actions Inactive
@ajewellamz ajewellamz merged commit 50b11f9 into aws:master Mar 7, 2023
@karkhaz karkhaz deleted the kk-add-cbmc-github-action branch March 7, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cbmc CBMC proof related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants