Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the version and type in deserializeMessageHeader #209

Closed
seebees opened this issue Sep 16, 2019 · 0 comments · Fixed by #217
Closed

Verify the version and type in deserializeMessageHeader #209

seebees opened this issue Sep 16, 2019 · 0 comments · Fixed by #217

Comments

@seebees
Copy link
Contributor

seebees commented Sep 16, 2019

Re #208, the error manifested as an invalid algorithm suite,
but the underlying issue was the message format.
If the version and type were verified as well,
the error message would have been better.
seebees added a commit to seebees/aws-encryption-sdk-javascript that referenced this issue Sep 18, 2019
@seebees
fix: version and type are required by the message format
8a91c04 
resolves aws#209

The version and type are required values.
This error will help clarify malformed messages.
Especialy string messages that have been encoded
and the proper encoding has not been passed.
@seebees seebees mentioned this issue Sep 18, 2019
Merged
1 task
seebees added a commit to seebees/aws-encryption-sdk-javascript that referenced this issue Sep 18, 2019
@seebees
fix: version and type are required by the message format
5d14443 
resolves aws#209

The version and type are required values.
This error will help clarify malformed messages.
Especially string messages that have been encoded
and the proper encoding has not been passed.
seebees added a commit that referenced this issue Sep 20, 2019
@seebees
fix: version and type are required by the message format (#217)
de30b36 
resolves #209

The version and type are required values.
This error will help clarify malformed messages.
Especially string messages that have been encoded
and the proper encoding has not been passed.

If the blob looks like it was base64 encoded,
note this in the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: version and type are required by the message format seebees/aws-encryption-sdk-javascript
1 participant
@seebees