chore: Add example for custom KMS client config #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally custom configuration for the AWS KMS client is needed. This is especially important in Discovery mode, But anytime you are dealing with more than one AWS KMS Key, the master key providers are simpler to work with then individual master keys.
mattsb42-aws
reviewed
Mar 9, 2022
Comment on lines
+35
to
+36
| self._register_client(client, region_name) | ||
| self._regional_clients[region_name] = client |
There was a problem hiding this comment.
Just a note: IMO by including this in the official examples, this implicitly blesses these private methods as part of the public API for this class. Not sure if that's an issue or not, depending on the plans for the future of the codebase. :)
There was a problem hiding this comment.
Yes, it may be better to refactor this example as:
main_mk = StrictAwsKmsMasterKeyProvider(providerConfig)
main_mk.add_master_key(MRKAwareKMSMasterKey(anotherConfig))
However this does not address discovery.
|
This will resolve #446. |
texastony
previously approved these changes
Nov 1, 2022
seebees
changed the title
kessplas
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally custom configuration for the AWS KMS client is needed.
This is especially important in Discovery mode,
But anytime you are dealing with more than one AWS KMS Key,
the master key providers are simpler to work with then individual master keys.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: