chore: remove manual edit comment from .NET TypeConversion #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
requested changes
Feb 2, 2024
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Right now, Smithy-Dafny is, regrettably, unstable.
I am working with @robin-aws to manage that.
But since we cannot "just generate" this fix,
we should not merge this.
I will come back and un-block this PR once Smithy-Dafny is stable.
Contributor
|
As @texastony says, this is pending work to confirm that smithy-dafny is correct now |
Contributor
|
This should be taken care of automatically when I apply the same changes to this repo as aws/aws-cryptographic-material-providers-library#195 |
Contributor
|
Updated from mainline which already has the change from #195, so the changeset is empty and no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes: Removes the "manual edit" comment tag from .NET TypeConversion.
This can be merged now that smithy-lang/smithy-dafny#311 is merged.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.