chore(examples): Raw ECDH and KMS ECDH #692
Conversation
RitvikKapila
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
RitvikKapila
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
RitvikKapila
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
RitvikKapila
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
RitvikKapila
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
AwsEncryptionSDK/runtimes/rust/examples/client_supplier/client_supplier_example.rs
Show resolved
Hide resolved
...st/examples/cryptographic_materials_manager/restrict_algorithm_suite/signing_only_example.rs
Show resolved
Hide resolved
|
|
||
| // Following are the helper functions for running ECDH examples | ||
|
|
||
| pub(crate) fn x962_to_x509( |
There was a problem hiding this comment.
i think this exists in the mpl
There was a problem hiding this comment.
Yes but that is an extern and it takes in an internal dafny type ECDHCurveSpec which I don't want to expose to customers. So this is a function which closely mimics the function in the externs.
There was a problem hiding this comment.
I would much rather us use the extern code because if the extern were to change then we would have to come and update this as well
There was a problem hiding this comment.
Once aws-lc-rs supports the various formats we need, we want to drop the dependence on aws-lc-sys.
If we keep the function public, we will have to support it forever. This will make the above update a blocking change. For Rust ECDH examples, I will create a function that mimics X962_to_X509 so that we can update it with the aws-lc-rs conversions once they are supported.
AwsEncryptionSDK/runtimes/rust/examples/keyring/ecdh/ephemeral_raw_ecdh_keyring_example.rs
Outdated
Show resolved
Hide resolved
AwsEncryptionSDK/runtimes/rust/examples/keyring/ecdh/ephemeral_raw_ecdh_keyring_example.rs
Show resolved
Hide resolved
AwsEncryptionSDK/runtimes/rust/examples/keyring/ecdh/kms_ecdh_discovery_keyring_example.rs
Show resolved
Hide resolved
AwsEncryptionSDK/runtimes/rust/examples/keyring/ecdh/kms_ecdh_discovery_keyring_example.rs
Outdated
Show resolved
Hide resolved
AwsEncryptionSDK/runtimes/rust/examples/keyring/ecdh/kms_ecdh_discovery_keyring_example.rs
Show resolved
Hide resolved
AwsEncryptionSDK/runtimes/rust/examples/keyring/ecdh/kms_ecdh_keyring_example.rs
Outdated
Show resolved
Hide resolved
RitvikKapila
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
This reverts commit 23ee72c.
josecorella
left a comment
josecorella
left a comment
There was a problem hiding this comment.
just have a question about the submodule bump, other than that lgtm
There was a problem hiding this comment.
are we also supposed to bump the submodule?
There was a problem hiding this comment.
Yes, it is already at MPL HEAD
There was a problem hiding this comment.
Thanks for taking a look at this
2 participants
Issue #, if available:
Description of changes:
aws-smithy-typesto1.2.8Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.