init: Extracts Availability Zone from ECS Task Metadata. #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjameswhitman
commented
Feb 4, 2023
| } | ||
|
|
||
| expectedContent1 := "export FLB_AWS_USER_AGENT=init\n" + | ||
| expectedContent1 := "export FLB_AWS_USER_AGENT=ecs-init\n" + |
There was a problem hiding this comment.
The default for this value appears to have changed in db3fd7f.
|
@johnjameswhitman Thank you for contributing this! Unfortunately, the team is a bit busy right now working on these: #542 I'll try to get you some review as soon as we can. |
PettitWesley
changed the title
There was a problem hiding this comment.
Thank you for this! I think the code looks good. Only thing I need to do to approve and merge this is run the manual test here: https://github.com/aws/aws-for-fluent-bit/tree/mainline/integ/test_init
Then we can include it in one of the next releases.
|
Thanks for the review @PettitWesley -- did you want me to run that test, or are you gonna do that yourself? |
Claych
approved these changes
Mar 1, 2023
|
init integ test passed with results shown in the screenshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #538
Description of changes: Makes a task's AZ available as an environment variable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.