Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Packet.hpp #75

Closed
wants to merge 2 commits into from
Closed

Update Packet.hpp #75

wants to merge 2 commits into from

Conversation

chamber-wang
Copy link

Workaround compile the aws-iot-device-sdk-cpp with Visual Studio Win64 #72

Workaround compile the aws-iot-device-sdk-cpp with Visual Studio Win64 aws#72
@vareddy-zz
Copy link
Contributor

Hi @chamber-wang ,
Thank you for this pull request!
We do not add annotations to code indicating the source of the change, could you please remove the comments? We use the commit history for tracking as much as possible.
After you remove the comments, we can test and merge it into master.
Thanks!
Varun

@vareddy-zz vareddy-zz changed the title Update Publish.hpp Update Packet.hpp Mar 16, 2018
Remove annotation accordingly.
@chamber-wang
Copy link
Author

Hi @vareddy
Appreciate for reply. Sure I have removed annotations accordingly.

vareddy-zz pushed a commit that referenced this pull request Apr 6, 2018
Includes #75, #76 and #77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows
@vareddy-zz
Copy link
Contributor

Included in this commit.

@vareddy-zz vareddy-zz closed this Apr 6, 2018
AWSSteveHa pushed a commit to AWSSteveHa/aws-iot-device-sdk-cpp that referenced this pull request Apr 20, 2018
Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload
AWSSteveHa added a commit to AWSSteveHa/aws-iot-device-sdk-cpp that referenced this pull request Apr 20, 2018
st commit's message is:

Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows
AWSSteveHa added a commit to AWSSteveHa/aws-iot-device-sdk-cpp that referenced this pull request Apr 20, 2018
Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload

indentation fixup
AWSSteveHa added a commit to AWSSteveHa/aws-iot-device-sdk-cpp that referenced this pull request Apr 20, 2018
Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload
AWSSteveHa added a commit to AWSSteveHa/aws-iot-device-sdk-cpp that referenced this pull request Apr 20, 2018
Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86
AWSSteveHa pushed a commit to AWSSteveHa/aws-iot-device-sdk-cpp that referenced this pull request Apr 20, 2018
Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload

Jobs support with custom auth support

Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Jobs support with custom auth support

Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload

Jobs support with custom auth support

Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload

indentation fixup

Wrap SIGPIPE in ifndef block for Windows

Allow Position Independent Code for Static Library (aws#73)

Build the static library with the fPIC compiler flag, so that it can be linked into a shared library.

Fix wildcard regex for special topics with $ symbols

Adding standard files (aws#83)

Pull requests to fix warnings on Windows

Includes aws#75, aws#76 and aws#77. Also includes other changes related to
- loading and storing of atomic variables
- fix for UTF-8 character representation on Windows

Update sample documentation with shadow client token limitation

Make Shadow::HandleGetResponse call response handler on Rejected response

Fixes aws#86

Make Shadow::HandleGetResponse call response handler on malformed payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants